This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 8d81963c01 Workaround type-incompatibility with new attrs in
openlineage (#30674)
8d81963c01 is described below
commit 8d81963c014398a7ab14505fd8e27e432f1aaf5c
Author: Jarek Potiuk <[email protected]>
AuthorDate: Sun Apr 16 23:44:14 2023 +0200
Workaround type-incompatibility with new attrs in openlineage (#30674)
The new attrs released today (11 hours ago) had added typing
information and they caused OpenLineageRedactor to fail mypy checks.
Temporary adding type: ignore should allow to upgrade to the new
attrs and stop PRs changing dependencies from failing.
Related: #30673
---
airflow/providers/openlineage/utils/utils.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/airflow/providers/openlineage/utils/utils.py
b/airflow/providers/openlineage/utils/utils.py
index b9c1e4a3de..0ed77fc608 100644
--- a/airflow/providers/openlineage/utils/utils.py
+++ b/airflow/providers/openlineage/utils/utils.py
@@ -341,8 +341,10 @@ class OpenLineageRedactor(SecretsMasker):
try:
if name and should_hide_value_for_key(name):
return self._redact_all(item, depth, max_depth)
+ # TODO: Those type: ignores here should be reviewed and fixed
+ # See: https://github.com/apache/airflow/issues/30673
if attrs.has(item): # type: ignore
- for dict_key, subval in attrs.asdict(item,
recurse=False).items():
+ for dict_key, subval in attrs.asdict(item,
recurse=False).items(): # type: ignore
if _is_name_redactable(dict_key, item):
setattr(
item,
