vincbeck commented on code in PR #30300:
URL: https://github.com/apache/airflow/pull/30300#discussion_r1168757358


##########
airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -143,8 +144,17 @@ def __init__(
     def _build_unload_query(
         self, credentials_block: str, select_query: str, s3_key: str, 
unload_options: str
     ) -> str:
+        # TODO: remove in provider 8.0.0
+        if "''" in select_query:
+            logging.warning(

Review Comment:
   I dont know any library doing that but that'd be cool. Otherwise, I am in 
favor of NOT managing these kind of use cases. These use cases (mix of quotes 
escaped and some unescaped) are not valid and users should fix it. The current 
implementation would not alter the string which, I think, is the correct 
behavior



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to