uranusjr commented on code in PR #30692:
URL: https://github.com/apache/airflow/pull/30692#discussion_r1169374248
##########
airflow/operators/python.py:
##########
@@ -518,7 +518,13 @@ def __init__(
self.python_version = python_version
self.system_site_packages = system_site_packages
self.pip_install_options = pip_install_options
- self.skip_exit_code = skip_exit_code
+ self.skip_on_exit_code = (
+ skip_on_exit_code
+ if isinstance(skip_on_exit_code, list)
Review Comment:
Would be better to do `isinstance` against either `int` or
`collections.abc.Container` instead, to allow e.g. `skip_on_exit_code=(1, 2)`.
No reason to restrict ourselves to just lists here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
