hussein-awala commented on code in PR #30641:
URL: https://github.com/apache/airflow/pull/30641#discussion_r1170458286


##########
airflow/models/xcom_arg.py:
##########
@@ -309,11 +310,26 @@ def zip(self, *others: XComArg, fillvalue: Any = NOTSET) 
-> ZipXComArg:
         return super().zip(*others, fillvalue=fillvalue)
 
     def get_task_map_length(self, run_id: str, *, session: Session) -> int | 
None:
+        from airflow.models.taskinstance import TaskInstance
         from airflow.models.taskmap import TaskMap
         from airflow.models.xcom import XCom
 
         task = self.operator
         if isinstance(task, MappedOperator):
+            unfinished_ti_count_query = 
session.query(func.count(TaskInstance.map_index)).filter(

Review Comment:
   Yes I meant something like`SELECT 1 FROM ...` (or select id) + `first()` 
which doesn't sent  a lot of data, but yes, I agree that there is no big 
difference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to