hussein-awala commented on code in PR #30733:
URL: https://github.com/apache/airflow/pull/30733#discussion_r1171176449
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -361,7 +362,12 @@ def __init__(
self.termination_grace_period = termination_grace_period
self.pod_request_obj: k8s.V1Pod | None = None
self.pod: k8s.V1Pod | None = None
- self.skip_exit_code = skip_exit_code
+ if skip_exit_code is not None:
+ warnings.warn(
+ "skip_exit_code is deprecated. Please use skip_on_exit_code",
DeprecationWarning, stacklevel=2
+ )
+ self.skip_on_exit_code = skip_exit_code
+ self.skip_on_exit_code = skip_on_exit_code
Review Comment:
Same comment here:
`self.skip_on_exit_code = skip_on_exit_code` overrides
`self.skip_on_exit_code = skip_exit_code` and replaces it by `None`, you need
to put it in `else`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
