dzhigimont commented on code in PR #30759:
URL: https://github.com/apache/airflow/pull/30759#discussion_r1172765876
##########
chart/templates/cleanup/cleanup-serviceaccount.yaml:
##########
@@ -21,6 +21,9 @@
{{- if and .Values.cleanup.serviceAccount.create .Values.cleanup.enabled }}
kind: ServiceAccount
apiVersion: v1
+{{- if hasKey .Values.cleanup.serviceAccount "automountServiceAccountToken" }}
Review Comment:
Not all services allow you to specify additional parameters for
serviceAccount for example cleanup. You should alter chart/values.schema.json.
Also, I think it's better to reflect the new available parameter with a default
value in the chart/values.json, because it's not clear where I should specify
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
