pankajkoti commented on PR #30500: URL: https://github.com/apache/airflow/pull/30500#issuecomment-1516923264
@vincbeck Thanks Vincent for the visibility on https://github.com/apache/airflow/pull/30032. On our(Astronomer's) end too, we're building/donating quite a few deferrable operators across various providers and would like to also see if most people agree to the pattern, then we could use this pattern not only for Amazon providers but for other providers too. Just curious to know if there was a prior discussion somewhere regarding following this pattern. I see that we're still keeping the `AwsBaseAsyncHook` in the hooks in the [PR](https://github.com/apache/airflow/pull/30032) which this PR leverages. I would like to create another PR for the cleanup later but for now, would request that in the meantime to review the other work if it looks good. cc: @pankajastro @phanikumv @kaxil 👆🏽 Please take a look at the pattern of using a single class for the hook with deferrable param for its methods and would appreciate your thoughts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
