josh-fell commented on code in PR #30781:
URL: https://github.com/apache/airflow/pull/30781#discussion_r1173227629
##########
airflow/providers/amazon/aws/transfers/s3_to_redshift.py:
##########
@@ -76,6 +76,7 @@ class S3ToRedshiftOperator(BaseOperator):
"column_list",
"copy_options",
"redshift_conn_id",
+ "method",
Review Comment:
The validation in the constructor of `self.method` against
`AVAILABLE_METHODS` will need to move to the `execute()` method of this
operator. Templated values are not rendered until _right before_ the
`execute()` method is called. So, if a `method`arg is a Jinja expression or an
XComArg, those explicit values will be checked against `AVAILABLE_METHODS`
instead of the rendered value and the task will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
