ferruzzi opened a new pull request, #30802:
URL: https://github.com/apache/airflow/pull/30802

   **Overview**
   Part of the ongoing OTel implementation.  Should not contain any logic 
changes, just moving things around into a more modular "plugin" style layout 
like we have elsewhere instead of the "monolithic" stats.py we currently have.
   
   @howardyoo and @potiuk: This is (my proposal for) the change we discussed 
yesterday.
   
   **Motivation**
   `airflow/stats.py` currently contains the metrics interface as well as 
implementations of the interface for StatsD and Datadog, some protocols, and 
validators (along with their interface).   This PR does not change any logic, 
simply moves related content into relevant modules.  For example All 
StatsD-specific code now lives in `airflow/metrics/statsd-logger.py`.  This is 
to make the stats.py file a bit cleaner, make adding OTel easier, and possibly 
make removing the StatsD easier later if we choose to go that route.
   
   When I add the OpenTelemetry code, it will live in 
`airflow/metrics/otel-logger.py`and simply import and implement the interfaces 
from `stats.py` and `metrics/protocols.py` instead of adding it to the existing 
growing monolith in `stats.py`.
   
   **Testing**
   Passes ``breeze static-checks --all-files` and `breeze testing tests 
--run-in-parallel` locally.
   
   cc:  @o-nikolas  @vincbeck @vandonr-amz @syedahsn 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to