potiuk commented on PR #30581: URL: https://github.com/apache/airflow/pull/30581#issuecomment-1518665622
I think it looks good in principle, but if I understand it correctly, it is heavily breaking change and it should have support to migrate existing permission that will work in general case. If I understand it - someone who currently has "CAN_EDIT" role will suddenly not be able to pause dags. In other words people who could pause dags, will suddenly loose this capability without a warning? If so, then this is a breaking change and we need to make sure that backwards compatibility is maintained. At the minimum level every role that currently has CAN_EDIT role should have CAN_PAUSE assigned during the migration. We have to remember, that our users could have their roles assigned in arbitrary way so making sure that ADMIN user has all the permissions is not enough, because our users could have different roles defined on their own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
