vchiapaikeo commented on PR #30655: URL: https://github.com/apache/airflow/pull/30655#issuecomment-1518676209
> I think the ideal fix is that run_query() is deprecated and cursor should instead call insert_job(), however, need the former to parse api_resource_configs from hook and build this into configuration for insert_job() This makes sense to me. You are suggesting we replace [this call to run_query](https://github.com/apache/airflow/blob/29fb38cfe3b0f1e54b48e7cc5786ab1c15ab8425/airflow/providers/google/cloud/hooks/bigquery.py#L2717) to use [insert_job](https://github.com/apache/airflow/blob/29fb38cfe3b0f1e54b48e7cc5786ab1c15ab8425/airflow/providers/google/cloud/hooks/bigquery.py#L1507) instead right? Would it be possible to refactor the api_resource_configs parsing done in run_query and call that within [execute](https://github.com/apache/airflow/blob/29fb38cfe3b0f1e54b48e7cc5786ab1c15ab8425/airflow/providers/google/cloud/hooks/bigquery.py#L2708)? Also, can we add a unit test or modify an existing one that shows no priority passed to the hook, the value of priority passed to insert_job within configuration, if it was passed it, and if it is set on the method itself? Nice work so far! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
