potiuk commented on PR #30691:
URL: https://github.com/apache/airflow/pull/30691#issuecomment-1518722736

   > AFAIU we don't need to create migration for roles because of they are 
syncing at start (managed by 
[AIRFLOW__WEBSERVER__UPDATE_FAB_PERMS](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#update-fab-perms))
   
   Does it include new roles that people create and assign them EDIT_DAG 
permissions ? 
   
   Are you sure of that ? (I am not - but checking if you checked this 
migration scenario). It's a heavily breaking change if it does not work. And I 
would be surprised if it did to be honest. How would the underlying know that 
we should replace EDIT_DAG with EDIT_DAG/TRIGGER_DAG combo ? Those seem to be 
two unrelated permissions now? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to