bolkedebruin commented on PR #30823:
URL: https://github.com/apache/airflow/pull/30823#issuecomment-1519113134

   Can you add a simple test in `test_serde.py` that tries to deserialize an 
existing/non-serialized object? And add a note to where you made the fix that 
or to that test as to why it is there (a decoder can travel both ways)? 
   
   Furthermore, I am not entirely happy with factoring Z out and putting it at 
the module level. Why not keep it in test_serde and reference it from the 
test_json? Or have a separate implementation in test_json as Z itself isnt 
really important.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to