durch commented on a change in pull request #5488: [AIRFLOW-4880] Add success, failure and fail_on_empty params to SqlSensor URL: https://github.com/apache/airflow/pull/5488#discussion_r305824397
########## File path: airflow/sensors/sql_sensor.py ########## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -from typing import Iterable +from typing import Iterable, Callable Review comment: I'd like to but the template fields on line 54 use the type annotation, thats probably taking down the Python 2 tests, should I clear those out as well (thats not my modification)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
