pgagnon commented on a change in pull request #5488: [AIRFLOW-4880] Add
success, failure and fail_on_empty params to SqlSensor
URL: https://github.com/apache/airflow/pull/5488#discussion_r305825342
##########
File path: tests/sensors/test_sql_sensor.py
##########
@@ -41,16 +41,16 @@ def setUp(self):
}
self.dag = DAG(TEST_DAG_ID, default_args=args)
- def test_unsupported_conn_type(self):
- t = SqlSensor(
- task_id='sql_sensor_check',
- conn_id='redis_default',
- sql="SELECT count(1) FROM INFORMATION_SCHEMA.TABLES",
- dag=self.dag
- )
-
- with self.assertRaises(AirflowException):
- t.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE,
ignore_ti_state=True)
+ # def test_unsupported_conn_type(self):
Review comment:
I think you should remove this comment block; maintainers for this project
generally do not like to keep commented code around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
