potiuk commented on code in PR #29842:
URL: https://github.com/apache/airflow/pull/29842#discussion_r1174981379
##########
airflow/providers/github/sensors/github.py:
##########
@@ -46,21 +48,32 @@ def __init__(
github_conn_id: str = "github_default",
method_params: dict | None = None,
result_processor: Callable | None = None,
+ allow_templates_in_result_processor: bool = True,
**kwargs,
) -> None:
super().__init__(**kwargs)
self.github_conn_id = github_conn_id
- self.result_processor = None
- if result_processor is not None:
- self.result_processor = result_processor
+ self.result_processor = result_processor
+ self.allow_templates_in_result_processor =
allow_templates_in_result_processor
self.method_name = method_name
self.method_params = method_params
- def poke(self, context: Context) -> bool:
+ def poke(self, context: Context, templated_fields: dict | None = None) ->
bool:
Review Comment:
Question: Maybe I do not understand someting, but how do you plan to use the
"templated_fields" here? From what I understand, `poke` method is called by
airflow without those optional "templated_fields", and when you use sensor in
your DAG "as is" you cannot really pass those templated_fields here..
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
