potiuk commented on PR #30839:
URL: https://github.com/apache/airflow/pull/30839#issuecomment-1520942060
> I think we should test all the providers when we change something in
airflow/models like the base sensor or operator. I don't see a test for that.
WDYT?
It's covered by the test below. This is actually the issue I mentioned with:
> I also found one case where core-changes did not trigger docs build for
Providers, which should not be the case, when we change core files, potentilly
all providers are affected (for tests, docs building and package preparation).
```
pytest.param(
(
"airflow/file.py",
"tests/providers/google/file.py",
),
{
"affected-providers": "",
"all-python-versions": "['3.7']",
"all-python-versions-list-as-string": "3.7",
"image-build": "true",
"needs-helm-tests": "false",
"run-tests": "true",
"docs-build": "true",
"docs-filter": "",
"run-kubernetes-tests": "false",
"upgrade-to-newer-dependencies": "false",
"skip-provider-tests": "false",
"parallel-test-types": "Core Providers[-amazon,google] Other
Providers[amazon] WWW "
"API Always CLI Providers[google]",
},
id="All tests should run if core file changed",
),
```
We already had this as a case where we decide that we should run all
provider tests where "essential" airflow core chnages. This means if there is a
change that is "airflow" sources but:
* not an API
* not a WWW
* not a CLI
* not providers
* not a chart/kubernetes_tests files
We decide to:
* run all Providers tests: "run-tests"= "true", parallel-tests-types has
"Providers" (split into three groups now)
* build all Providers docs (fixed in this PR) -> docs_filter = "",
docs-build="true"
* (added in this PR) build and install all providers -> afffected_providers
= "" (means build all providers to check them)
Yeah, likele we could still refactor it (I think it would have been better
to distinguish the values of those two for case where we skip them alltogether
but for now it is what it is - for now guarded by the test cases).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
