babinos87 commented on code in PR #30762: URL: https://github.com/apache/airflow/pull/30762#discussion_r1176628404
########## airflow/migrations/versions/0125_2_6_0_add_index_to_task_instance_table.py: ########## @@ -0,0 +1,50 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Add index to task_instance table + +Revision ID: a58082ab9b0e +Revises: 98ae134e6fff +Create Date: 2023-04-19 16:48:06.628863 + +""" +from __future__ import annotations + +from alembic import op + +# revision identifiers, used by Alembic. +revision = "a58082ab9b0e" +down_revision = "98ae134e6fff" +branch_labels = None +depends_on = None +airflow_version = "2.6.0" Review Comment: Changing https://github.com/apache/airflow/blob/main/airflow/__init__.py#L29 produces a bunch of other changes by `pre-commit run`. Some changes are propose by it, for example: ``` ... Check that the REVISION_HEADS_MAP is up-to-date........................................Failed - hook id: check-revision-heads-map - exit code: 3 Current airflow version is not in the REVISION_HEADS_MAP Current airflow version: 2.6.1 Please add the version to the REVISION_HEADS_MAP at: /home/rais/Desktop/workspace/airflow/airflow/utils/db.py Update version to the latest version in the documentation..............................Failed - hook id: update-version - files were modified by this hook ... ``` (btw `2.6.0` is not listed in https://github.com/apache/airflow/blob/main/airflow/utils/db.py#L55, I am not sure how this works). And I have find a few other places where `2.6.0` is hard-coded, for example: https://github.com/apache/airflow/blob/main/dev/validate_version_added_fields_in_config.py#L45 - I am not sure whether I would have to change this too? Should I modify all those files that are produced? I am not sure if this should be done as part of this PR, or someone else should cut a new release? Perhaps I should wait until this happens? I am not very familiar with this procedure. I don't mind to try, but would need to spam you with questions probably. Please let me know how should I proceed. @ephraimbuddy @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
