phanikumv commented on code in PR #30244:
URL: https://github.com/apache/airflow/pull/30244#discussion_r1179473482
##########
airflow/providers/amazon/aws/operators/redshift_cluster.py:
##########
@@ -624,8 +629,15 @@ def __init__(
self._attempts = 10
self._attempt_interval = 15
self.redshift_hook = RedshiftHook(aws_conn_id=aws_conn_id)
+ self.aws_conn_id = aws_conn_id
+ self.deferrable = deferrable
+ self.max_attempts = max_attempts
+
+ if self.deferrable and self.wait_for_completion:
+ raise AirflowException("Both wait_for_completion and deferrable
can't be True.")
Review Comment:
We followed this review suggestion from @kaxil last time in dbt operators
w.r.t `wait_for_completion` vs `deferrable`. I suggest to follow the same
https://github.com/apache/airflow/pull/29014#discussion_r1073723719
##########
airflow/providers/amazon/aws/operators/redshift_cluster.py:
##########
@@ -624,8 +629,15 @@ def __init__(
self._attempts = 10
self._attempt_interval = 15
self.redshift_hook = RedshiftHook(aws_conn_id=aws_conn_id)
+ self.aws_conn_id = aws_conn_id
+ self.deferrable = deferrable
+ self.max_attempts = max_attempts
+
+ if self.deferrable and self.wait_for_completion:
+ raise AirflowException("Both wait_for_completion and deferrable
can't be True.")
Review Comment:
We followed this review suggestion from @kaxil last time in dbt operators
w.r.t `wait_for_completion` vs `deferrable`. I suggest to follow the same
https://github.com/apache/airflow/pull/29014#discussion_r1073723719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]