josh-fell commented on code in PR #30919:
URL: https://github.com/apache/airflow/pull/30919#discussion_r1179513418
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -276,7 +276,15 @@ def find_all_providers_affected(
"to make changes to the provider."
)
get_console().print(f"Suspended providers: {suspended_providers}")
- sys.exit(1)
+ if fail_if_suspended_providers_affected:
+ get_console().print(
+ "[error]This PR did not have `allow suspended provider
changes` " "label set so it will fail."
Review Comment:
```suggestion
"[error]This PR did not have `allow suspended provider
changes` label set so it will fail."
```
Some black shenanigans I think?
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -276,7 +276,15 @@ def find_all_providers_affected(
"to make changes to the provider."
)
get_console().print(f"Suspended providers: {suspended_providers}")
- sys.exit(1)
+ if fail_if_suspended_providers_affected:
+ get_console().print(
+ "[error]This PR did not have `allow suspended provider
changes` " "label set so it will fail."
+ )
+ sys.exit(1)
+ else:
+ get_console().print(
+ "[info]This PR had `allow suspended provider changes` label
set so it will " "continue"
Review Comment:
```suggestion
"[info]This PR had `allow suspended provider changes` label
set so it will continue"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]