potiuk commented on code in PR #30166:
URL: https://github.com/apache/airflow/pull/30166#discussion_r1180202216
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -585,41 +622,70 @@ def __init__(
partition_clause: str | None = None,
conn_id: str | None = None,
database: str | None = None,
+ accept_none: bool = True,
Review Comment:
Yeah. I am usually in the camp of "breaking change is only determined by how
likely it is to change other's workflow" :). I **think** this case is where
it's not very likely somoene treats none as false (though I must say I have
never used that operator).
@pankajastro @denimalpaca - > maybe you have some examples of how people are
using the operator and elaborate on how likely it is that the breaking
behaviour will kick in ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
