[
https://issues.apache.org/jira/browse/AIRFLOW-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890539#comment-16890539
]
ASF GitHub Bot commented on AIRFLOW-4929:
-----------------------------------------
eeshugerman commented on pull request #5641: [AIRFLOW-4929][Revision] Improve
display of JSON Variables in UI
URL: https://github.com/apache/airflow/pull/5641
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title: https://issues.apache.org/jira/browse/AIRFLOW-4929
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
I accidently added some bad (but functioning) code with
https://github.com/apache/airflow/pull/5573. This PR fixes it. I will add a
comment below with more details.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Pretty display of Json variables in UI
> --------------------------------------
>
> Key: AIRFLOW-4929
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4929
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ui
> Affects Versions: 1.10.4
> Reporter: Hover
> Priority: Major
> Fix For: 1.10.5
>
>
> Currenly the UI shows the val of Variable as plain text.
> Sometimes the val is Json or even nested Json it's very hard to understand
> what you are seeing when it's just one line of text.
> It would be greate if Airflow can also allow to view it as Json format.
> If it's too hard to develop than maybe by clicking on the cell it will
> forward to [https://jsonformatter.curiousconcept.com/] paste the text and
> display it in formatted way
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
