potiuk commented on code in PR #30943:
URL: https://github.com/apache/airflow/pull/30943#discussion_r1180645330
##########
airflow/models/abstractoperator.py:
##########
@@ -564,7 +566,7 @@ def _do_render_template_fields(
f"{attr_name!r} is configured as a template field "
f"but {parent.task_type} does not have this attribute."
)
- if not value:
+ if isinstance(value, pd.DataFrame) or not value:
Review Comment:
Is there any place where we think actually raising an exception here would
help? I think just continuing on ValueError would make it more resilient to any
problematic classes that are ambiguous whether they are truthful or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
