eladkal commented on code in PR #30975:
URL: https://github.com/apache/airflow/pull/30975#discussion_r1181274309


##########
airflow/providers/sqlite/operators/sqlite.py:
##########
@@ -49,6 +50,6 @@ def __init__(self, *, sqlite_conn_id: str = "sqlite_default", 
**kwargs) -> None:
         warnings.warn(
             """This class is deprecated.
             Please use 
`airflow.providers.common.sql.operators.sql.SQLExecuteQueryOperator`.""",
-            DeprecationWarning,
+            AirflowProviderDeprecationWarning,

Review Comment:
   yeah that is a good idea to do anyway!
   
   My question here is to raise the two options:
   1. Since our policy states that all providers are 2.4 compatible leave this 
as is and if users will face it then they will have to downgrade - Not user 
friendly and I hope to avoid this!
   2. Add try/catch to support both imports thus being compatible with older 
versions of Airflow. This is kinda against our policy but this prevents the 
potential issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to