potiuk commented on PR #30923: URL: https://github.com/apache/airflow/pull/30923#issuecomment-1530426308
Type change is not really breaking IMHO. We do not have a definition of what Breaking change is and mainly because it is impossible. [Hyrum's law](https://www.hyrumslaw.com/) succintly describes it and the obligatory XKCD comic shows a good example of it [1]. So we always have to rely on personal judgment on when a change is likely to break many people's "production" workflow. This one might easily break someone's CI workflow for example. But it is extremely unlikely to break production workflow. There are few cases only when type-hinting is used at runtime with the capacity of breaking things (for example when it is used in Pydantic definition of data objects being serialized). If your code worked before the change and correctly handled S3 objects returned, it will continue to work, if it did not handle some edge cases, and your MyPy might not have flagged it before, but it will continue to NOT work the same way it did NOT work before. So this one is definitely not breaking. your CI might break, but this is not a breaking change for airlfow release. [1] Obligatory XKCD  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
