potiuk commented on code in PR #30999:
URL: https://github.com/apache/airflow/pull/30999#discussion_r1182163603
##########
scripts/in_container/verify_providers.py:
##########
@@ -826,6 +828,12 @@ def run_provider_discovery():
subprocess.run(["airflow", "providers", "secrets"], check=True)
console.print("[bright_blue]List all auth backends[/]\n")
subprocess.run(["airflow", "providers", "auth"], check=True)
+ if version > "2.6.0":
Review Comment:
This comparison is technically wrong. String comparison does not work for
package versions. For example 2.10.0 will be less than 2.6.0. see example of
comparison i do in https://github.com/apache/airflow/pull/30994 for good
comparision example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
