eladkal commented on code in PR #30994:
URL: https://github.com/apache/airflow/pull/30994#discussion_r1182902936


##########
dev/provider_packages/prepare_provider_packages.py:
##########
@@ -1318,6 +1327,25 @@ def update_release_notes(
     return True
 
 
+def update_min_airflow_version(provider_package_id: str, version_suffix: str):
+    provider_details = get_provider_details(provider_package_id)
+    provider_info = get_provider_info_from_provider_yaml(provider_package_id)
+    jinja_context = get_provider_jinja_context(
+        provider_info=provider_info,
+        provider_details=provider_details,
+        current_release_version=provider_details.versions[0],
+        version_suffix=version_suffix,
+    )
+    generate_init_py_file_for_provider(
+        context=jinja_context,
+        target_path=provider_details.source_provider_package_path,
+    )
+    if not jinja_context["PREINSTALLED_PROVIDER"]:
+        replace_min_airflow_version_in_provider_yaml(
+            context=jinja_context, 
target_path=provider_details.source_provider_package_path
+        )

Review Comment:
   Where is the part that skip this for providers in the version exception list?
   We don't want min version 2.6 to be override with 2.5



##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -172,83 +172,91 @@ def release_management():
 
 
 @release_management.command(
-    name="prepare-airflow-package",
-    help="Prepare sdist/whl package of Airflow.",
+    name="prepare-provider-documentation",
+    help="Prepare CHANGELOG, README and COMMITS information for providers.",
 )
-@option_package_format
-@option_version_suffix_for_pypi
 @option_debug_release_management
+@argument_packages
[email protected](
+    "--base-branch",
+    type=str,
+    default="main",
+    help="Base branch to use as diff for documentation generation (used for 
releasing from old branch)",
+)
 @option_github_repository
[email protected](
+    "--only-min-version-update",

Review Comment:
   This is very cool!
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to