jedcunningham commented on code in PR #31024:
URL: https://github.com/apache/airflow/pull/31024#discussion_r1182943535
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -164,9 +164,9 @@ def push_artifacts_to_asf_repo(version, repo_root):
check=True,
)
console_print("Files pushed to svn")
+ os.chdir(repo_root)
Review Comment:
I don't think you should need this change. `remove_old_releases` moves to a
different dir anyways, then moves back to the repo root.
##########
dev/breeze/src/airflow_breeze/commands/release_command.py:
##########
@@ -49,25 +50,13 @@ def create_version_dir(version):
console_print(f"{version} directory created")
-def copy_artifacts_to_svn(rc, svn_dev_repo):
+def copy_artifacts_to_svn(rc, svn_dev_repo, svn_version_dir):
if confirm_action(f"Copy artifacts to SVN for {rc}?"):
- run_command(
- [
- "for",
- "f",
- "in",
- f"{svn_dev_repo}/{rc}/*",
- ";",
- "do",
- "svn",
- "cp",
- "$f",
- "${$(basename $f)/}",
- "done",
- ],
- dry_run_override=DRY_RUN,
- check=True,
- )
+ dev_rc_path = f"{svn_dev_repo}/{rc}/"
+ if not DRY_RUN:
+ for filename in os.listdir(dev_rc_path):
+ source_file = os.path.join(dev_rc_path, filename)
+ shutil.copy(source_file, svn_version_dir)
Review Comment:
I think we should continue to use svn cp. Most notably, this will use more
disk space I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
