ephraimbuddy commented on code in PR #30970:
URL: https://github.com/apache/airflow/pull/30970#discussion_r1183489310
##########
tests/charts/airflow_aux/test_basic_helm_chart.py:
##########
@@ -37,13 +37,11 @@ def _get_values_with_version(self, values, version):
return values
def _get_object_count(self, version):
- if version == "2.3.2":
- return OBJECT_COUNT_IN_BASIC_DEPLOYMENT + 1
- elif version == "2.6.0":
+ if version == "2.3.2" or version == "default":
return OBJECT_COUNT_IN_BASIC_DEPLOYMENT + 1
return OBJECT_COUNT_IN_BASIC_DEPLOYMENT
- @pytest.mark.parametrize("version", ["2.3.2", "2.4.0", "2.6.0", "default"])
+ @pytest.mark.parametrize("version", ["2.3.2", "2.4.0", "default"])
Review Comment:
2.6.0 is now the default, so no need to have it and also have a default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
