jon-evergreen commented on code in PR #31037:
URL: https://github.com/apache/airflow/pull/31037#discussion_r1183602341
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -622,8 +622,6 @@ def execute(self, context: Context):
self.log.info("All tests have passed")
def _generate_sql_query(self):
- self.log.info("Partition clause: %s", self.partition_clause)
Review Comment:
I know I added that logging line while I was debugging some templating
issues so it hasn't been around long. The function call itself needs to be in
`__init__()` so the results gets templated correctly.
This is also why I think the log line is redundant and can be safely
removed: the templated `partition_clause` is available via the airflow UI so
people can see it (or the lack of it). I could see an argument for logging out
the full query in the execute function for a "this is what ran" vs "this is
what you can see through the UI", but the line this PR removes doesn't seem
worthwhile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
