uranusjr commented on code in PR #31028:
URL: https://github.com/apache/airflow/pull/31028#discussion_r1184100643
##########
airflow/config_templates/default_celery.py:
##########
@@ -67,14 +68,14 @@ def _broker_supports_visibility_timeout(url):
try:
if celery_ssl_active:
- if broker_url and "amqp://" in broker_url:
+ if broker_url and re.search("amqp://", broker_url):
Review Comment:
Please don’t use `re.search` for this, it’s a lot slower. I can _maybe_ see
the point using it for more complex matches below, but this one definitely
should not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
