uranusjr commented on code in PR #30730:
URL: https://github.com/apache/airflow/pull/30730#discussion_r1184139118
##########
airflow/providers/docker/operators/docker.py:
##########
@@ -291,6 +296,9 @@ def __init__(
if skip_on_exit_code
else []
)
+ self.port_bindings = port_bindings or {}
Review Comment:
Alternatively, maybe an empty list/dict actually works for Docker’s API?
It’d be awesome if you could check; if it does the code could be much simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
