potiuk commented on PR #31033: URL: https://github.com/apache/airflow/pull/31033#issuecomment-1534466680
General comment here. Honestly I think we should merge that one first - because it is very likely we are going to cherry-pick this one to 2.6.1 while #30727 is much more risky to cherry-pick to bugfix branch. This one should cherry-pick cleanly if we merge it first, whereas if we merge it after #30727 it will require manually applying the same fix to 2.6.1 branch. This is also why I hesitated a bit with #30727 refactoring and where my comment about possibly splitting it even further came from @o-nikolas. This is a nice example how such refactorings are impacting our bug-fixing releases. Somethign to consider when we decide to merge #30727 (also something for @ephraimbuddy and @pierrejeambrun to take a look I guess) - for me the kind of more complex refactors in "core" parts of Airflow are better done closer to the end of cherry-picking cycle when we are preparing to cut-off a new minor branch (this is one of the reasons why the base_job refactor of mine was done when it was done - after the last cherry-pickign round for 2.5.*) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
