jbbqqf commented on code in PR #30658:
URL: https://github.com/apache/airflow/pull/30658#discussion_r1185425228


##########
airflow/providers/google/cloud/transfers/bigquery_to_mssql.py:
##########
@@ -18,19 +18,18 @@
 """This module contains Google BigQuery to MSSQL operator."""
 from __future__ import annotations
 
+import warnings
 from typing import TYPE_CHECKING, Sequence
 
-from airflow.models import BaseOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook
 from airflow.providers.google.cloud.links.bigquery import BigQueryTableLink
-from airflow.providers.google.cloud.utils.bigquery_get_data import 
bigquery_get_data
+from airflow.providers.google.cloud.transfers.bigquery_to_sql import 
BigQueryToSqlBaseOperator
 from airflow.providers.microsoft.mssql.hooks.mssql import MsSqlHook
 
 if TYPE_CHECKING:
     from airflow.utils.context import Context
 
 
-class BigQueryToMsSqlOperator(BaseOperator):
+class BigQueryToMsSqlOperator(BigQueryToSqlBaseOperator):

Review Comment:
   Yes it is intentional. There was a slight difference between the MySQL 
documentation and the MsSQL documentation. I standardized the location of the 
example snippet. I used the MsSQL version. It did not require to change the 
MsSQL version, but this is why there is a change on the MySQL version.
   
   As for the new interface (`s/mssql_table/target_table_name/`), it has been 
changed directly in `example_bigquery_to_mssql.py`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to