notatallshaw-gts commented on PR #31073: URL: https://github.com/apache/airflow/pull/31073#issuecomment-1536484661
> IMO this needs to be tested, even if it looks trivial. We should avoid the possibility of someone accidentally breaking it. You can add two tests, one with the session argument and one without. Agreed, I'll create some new tests (fyi it may take me a few days to update this when I have the time to work on it) > And for the failed tests, since there is no argument to activate/deactivate the retry (we can do this by providing a None session), you should fix all of them. Sure I can do this > I think we can replace the `mock_hvac.Client.assert_called_with` by getting the call args and compare the urls, otherwise you need to get the session from the kwargs and compare it to the passed session, which is useless. I'm not sure I follow, if I fix the tests by passing `session=None` as stated above what do you want to do with a url? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
