VVildVVolf commented on code in PR #31082:
URL: https://github.com/apache/airflow/pull/31082#discussion_r1186306282
##########
airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -600,7 +600,7 @@ def __init__(
options: dict[str, Any] | None = None,
dataflow_default_options: dict[str, Any] | None = None,
parameters: dict[str, str] | None = None,
- location: str = DEFAULT_DATAFLOW_LOCATION,
+ location: str | None = None,
Review Comment:
Also additional level of protection can be provided at
[_fallback_variable_parameter
method](https://github.com/apache/airflow/blob/793d36f013efa191e7732faf6e624cdd1d83ebae/airflow/providers/google/cloud/hooks/dataflow.py#LL85C5-L85C33),
but looks redundant since the default value is caught from the
[DataflowHook.start_template_dataflow](https://github.com/apache/airflow/blob/793d36f013efa191e7732faf6e624cdd1d83ebae/airflow/providers/google/cloud/hooks/dataflow.py#L621)
definition itself. Please let me know if it is useful - I can publish the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
