potiuk commented on issue #10385: URL: https://github.com/apache/airflow/issues/10385#issuecomment-1537891320
I think yes - the operator it's been deprecated with also misses the `on_kill` - we have been discussing that with @eladkal recently and I think all the operators that start some external job should have an `on_kill` implemented to be able to cancel running job when it is marked as failed/cleared and it is still running (unless it cleans up after itself automatically - for example cancelling a job that has an opened SQL query via dbapi will automatically close the connection and cancel such running query). I think in general, it would be nice to identify all such operators that miss proper cleaning, and implement on_kill methods for them. Maybe a good idea for some kind of spring cleanup :D ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
