ephraimbuddy commented on code in PR #31024:
URL: https://github.com/apache/airflow/pull/31024#discussion_r1187209661


##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -164,9 +164,9 @@ def push_artifacts_to_asf_repo(version, repo_root):
             check=True,
         )
         console_print("Files pushed to svn")
+        os.chdir(repo_root)
         # Remove old releases
         remove_old_releases(version, repo_root)
-        os.chdir(repo_root)
         run_command(["rm", "-rf", "asf-dist"], dry_run_override=DRY_RUN, 
check=True)

Review Comment:
   I think it would be packaged into the pypi package if we don't remove the 
asf-dist at this step. Do you prefer we check it out again when we want to 
check for the old releases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to