jens-scheffler-bosch commented on code in PR #30704:
URL: https://github.com/apache/airflow/pull/30704#discussion_r1187920128
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1083,8 +1084,11 @@ def _do_scheduling(self, session: Session) -> int:
callback_tuples = self._schedule_all_dag_runs(guard, dag_runs,
session)
# Send the callbacks after we commit to ensure the context is up to
date when it gets run
+ # cache saves time during scheduling of many dag_runs for same dag
+ cached_get_dag: Callable = lru_cache()(lambda dag_id:
self.dagbag.get_dag(dag_id, session=session))
Review Comment:
I tried to think about how the `functools.partial` could make it better. The
proposed statement is a one-liner in adding the `@lru_cache` decorator inline
w/o a local additional function declaration. How do you mean it would be better?
In my VSCode at least it shows type hints from parsing python, resulting
callable is hinted and the returned `dag` variable in line 1090 is displayed as
`(variable) dag: DAG | None` - is it displayed w/o type hints in your IDE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
