uranusjr commented on code in PR #31136:
URL: https://github.com/apache/airflow/pull/31136#discussion_r1187987102
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -258,6 +258,9 @@ def _process_output(self, results: list[Any], descriptions:
list[Sequence[Sequen
self.log.info("Operator output is: %s", results)
return results
+ def _run_output_processing(self) -> bool:
Review Comment:
This name sounds like the function actually runs the processing, but in
reality it only returns whether processing _should_ be done. Maybe prefix the
name with `should`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
