potiuk opened a new pull request, #31181: URL: https://github.com/apache/airflow/pull/31181
There are several improvements for the docker-compose tests of ours. They have not been well documented and explained, also they had problems with running in the new docker-comppose v2 environment. The healthcheck failures were not easy to debug as well when they failed in CI. This PR fixes all the problems: * TESTING.rst describes the tests explains how they work and provides instructions on how to reproduce them locally and debug them * The test now check which version of docker-compose is available and act accordingly (both v2 and v1 version are automatically supported) * When the test fails, additionally to docker compose logs and process status, the state of all health checks is dumped so that it is clear why the health check failed * A way is added to not shut down docker-compose after the test complete, which allows to inspect them <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
