potiuk commented on code in PR #31182:
URL: https://github.com/apache/airflow/pull/31182#discussion_r1189981203
##########
airflow/jobs/dag_processor_job_runner.py:
##########
@@ -53,6 +53,7 @@ def __init__(
f"The job is already assigned a different job_type:
{job.job_type}."
f"This is a bug and should be reported."
)
+ self.job.job_type = self.job_type
Review Comment:
There will be additional problems if you try to extract it to common code
especially if you want to add typing to job because of circular dependencies
it will create - I think the original solution wil be better (at least for
now). We can refactor it in the future when we complete AIP-44. It's solvable
but I would focus on solvin this the simplest possible way now ie ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
