bbovenzi commented on code in PR #30950:
URL: https://github.com/apache/airflow/pull/30950#discussion_r1190171541
##########
airflow/www/static/js/dag/details/taskInstance/taskActions/ClearInstance.tsx:
##########
@@ -77,6 +78,10 @@ const ClearInstance = ({
const [failed, setFailed] = useState(false);
const onToggleFailed = () => setFailed(!failed);
+ const initialClearButtonFocusRef = useRef<HTMLButtonElement>(null);
+
+ useKeysPress("shiftKey", ['c', 'C'], onOpen);
Review Comment:
Looking good! Do we want to add a cheatsheet somewhere?
Also, for adding a note, we should make sure to toggle the accordion open if
it is closed.
##########
airflow/www/static/js/dag/details/taskInstance/taskActions/ClearInstance.tsx:
##########
@@ -77,6 +78,10 @@ const ClearInstance = ({
const [failed, setFailed] = useState(false);
const onToggleFailed = () => setFailed(!failed);
+ const initialClearButtonFocusRef = useRef<HTMLButtonElement>(null);
+
+ useKeysPress("shiftKey", ['c', 'C'], onOpen);
Review Comment:
Looking good!
Do we want to add a cheatsheet somewhere?
Also, for adding a note, we should make sure to toggle the accordion open if
it is closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
