VVildVVolf commented on issue #31156:
URL: https://github.com/apache/airflow/issues/31156#issuecomment-1543728071

   The problem is related to `flask-appbuilder`. To be precise, [it's usage of 
select2](https://github.com/dpgaspar/Flask-AppBuilder/blob/6bda240422e4100bd2e223b0b7ff52c09f18ddef/flask_appbuilder/static/appbuilder/js/ab_filters.js#L143):
   
   You can see in address bar, after clicking "Search", the address would 
became `/taskinstance/list/?_flt_undefined_state=failed`. But if you change it 
manually to something like `/taskinstance/list/?_flt_3_state=failed`, you will 
see that everything works fine. So, the problem does not look on airflow side.
   
   Please, correct me if you see different picture.
   
   I created [a PR for 
fba](https://github.com/dpgaspar/Flask-AppBuilder/pull/2039) according to 
[select2's 
recommendation](https://github.com/select2/select2/blob/4de1d236e602149a5c78d35899b49b3989b94107/src/js/select2/core.js#LL519C10-L519C75),
 but not sure if it will be merged (at least soon).
   
   On the other hand, looks like it [might hard to update fba for the airflow 
itself](https://github.com/apache/airflow/blob/60536152b2466dcfab6a7323ae58beb0867caad1/README.md?plain=1#L384-L385).
   
   @potiuk, can we theoretically upgrade fba to 4.3.1? looks like [fba already 
has some changes of this 
point](https://github.com/dpgaspar/Flask-AppBuilder/commit/5529e9a7ab6c42a1f90c25ae7f876e0f9bf19b4b#diff-22f5f0ee59615804cfa9a64e69a21b144c0a94405782d0240c203bcfddc78f5d),
 but honesly not sure if it does fix the problem itself yet (because of P.S. 
bellow).
   P.S. I tried to check 4.3.1 locally (PR: 
https://github.com/apache/airflow/pull/31203), but breeze says that there is a 
restriction to use 4.3.1 instead of 4.3.0. I have not found yet how to disable 
it, if you would provide a hint - it will be very helpfull :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to