vandonr-amz commented on code in PR #31191:
URL: https://github.com/apache/airflow/pull/31191#discussion_r1191400123
##########
tests/system/providers/amazon/aws/example_eks_with_fargate_in_one_step.py:
##########
@@ -106,13 +106,15 @@
describe_pod = BashOperator(
task_id="describe_pod",
- bash_command=""
- # using reinstall option so that it doesn't fail if already present
- "install_aws.sh --reinstall " "&& install_kubectl.sh --reinstall "
- # configure kubectl to hit the cluster created
- f"&& aws eks update-kubeconfig --name {cluster_name} "
- # once all this setup is done, actually describe the pod
- "&& kubectl describe pod {{ ti.xcom_pull(key='pod_name',
task_ids='run_pod') }}",
+ bash_command=f"""
+ install_aws.sh || true;
+ install_kubectl.sh || true;
+ # configure kubectl to hit the cluster created
Review Comment:
yeah, I properly tested it this time (I hope !).
But I don't understand what triple quotes would change here... In the end,
whether you use triple quotes or single or load it from a file, it's always the
same bytes being stored in memory.
Maybe I could keep the previous format and add extra escaped quotes to have
the thing interpreted as a whole ?
I got the idea for the `;` from https://naiveskill.com/airflow-bashoperator/
because most examples/doc only show it being used with one simple command...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
