o-nikolas commented on code in PR #30727:
URL: https://github.com/apache/airflow/pull/30727#discussion_r1191764509
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -834,7 +429,7 @@ def try_adopt_task_instances(self, tis:
Sequence[TaskInstance]) -> Sequence[Task
tis_to_flush_by_key = {ti.key: ti for ti in tis if ti.queued_by_job_id}
kube_client: client.CoreV1Api = self.kube_client
for scheduler_job_id in scheduler_job_ids:
- scheduler_job_id =
pod_generator.make_safe_label_value(str(scheduler_job_id))
+ scheduler_job_id =
self._make_safe_label_value(str(scheduler_job_id))
Review Comment:
Yeah, I noticed that as well, I'd like to minimize the functional changes in
this PR though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
