uranusjr commented on code in PR #31216:
URL: https://github.com/apache/airflow/pull/31216#discussion_r1191979517
##########
airflow/utils/email.py:
##########
@@ -241,27 +241,33 @@ def send_mime_email(
smtp_user = None
smtp_password = None
+ found_email_connection = False
if conn_id is not None:
try:
from airflow.hooks.base import BaseHook
airflow_conn = BaseHook.get_connection(conn_id)
smtp_user = airflow_conn.login
smtp_password = airflow_conn.password
+ found_email_connection = True
except AirflowException:
pass
- if smtp_user is None or smtp_password is None:
Review Comment:
I’d argue the `smtp_... = airflow_conn...` lines should be moved to the else
block as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
