uranusjr commented on code in PR #30699:
URL: https://github.com/apache/airflow/pull/30699#discussion_r1193271836
##########
airflow/models/dagrun.py:
##########
@@ -344,7 +344,7 @@ def next_dagruns_to_examine(
return with_row_locks(
query.limit(max_number), of=cls, session=session,
**skip_locked(session=session)
- )
+ ).all()
Review Comment:
I feel adding this in `_start_queued_dagruns` instead may be the better
abstraction. In the other place this is called (`_do_scheduling`) adding
`all()` would make performance worse (one additional iteration and more memory
usage) since ther the iterable is only walked through once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
