o-nikolas commented on PR #31001: URL: https://github.com/apache/airflow/pull/31001#issuecomment-1548222243
> This will be only for the "old" ways -> it will not slow down things **too much**. It's basically when .app is imported in the module, the lookup has to be done if there is a dynamic attribute defined, deprecation warning printed, and "real" import returned instead - so. this is mostly the extra lookup + print delay (but it makes sense to get is slower a bit rather than stopping working altogether. Especially that those liveness probes/health checks are also pretty arcane knowledge for users and they sometimes do not realise they exist and just see "restarting worker". Actually, this has me thinking, the very slow part is importing the celery bits and constructing the app (mostly the former), so if I just defer the import in a dynamic attribute on celery_executor.py, then that actually suits all my needs for this PR perfectly fine. There would be no need to deprecate anything as far as the user is concerned and the number of changes in this PR will shrink quite a bit. I'll play around with this today and see if all the tests still pass as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
