uranusjr commented on code in PR #29433:
URL: https://github.com/apache/airflow/pull/29433#discussion_r1197304770
##########
airflow/api_connexion/endpoints/dataset_endpoint.py:
##########
@@ -120,3 +130,40 @@ def get_dataset_events(
return dataset_event_collection_schema.dump(
DatasetEventCollection(dataset_events=events,
total_entries=total_entries)
)
+
+
[email protected]_access([(permissions.ACTION_CAN_CREATE,
permissions.RESOURCE_DATASET)])
+@provide_session
+def post_dataset_event(session: Session = NEW_SESSION) -> APIResponse:
+ """Create an external dataset event. This endpoint is useful if you want
to update a dataset and
+ trigger downstream DAG runs from external services.
+ """
+ try:
+ json_body = dataset_change_schema.load(get_json_request_dict())
+ except ValidationError as err:
+ raise BadRequest(detail=str(err))
+ uri = json_body["dataset_uri"]
+ external_source = request.remote_addr
+ user_id = getattr(current_user, "id", None)
Review Comment:
Instead of ID, I feel this should use the username. The ID from database
should be considered kind of an implementation detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
